Fake Product UUID Case Sensitivity Incorrect on Rockstor 4 (#2290) #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2290) As Rockstor 4 is associated with newer kernel versions by default, which in turn now produce lowercase product uuid's, we fail in the majority of cases to match against our mixed case tuple of know fake product uuids. Fix by normalising on lowercase in line with the sited uuid standard of: rfc4122 as per the kernel. Includes formatting clean-ups of the known fake product uuids. N.B. no functional change is made to how an existing install, of the same major version, generates it's Appliance ID.
|
@FroggyFlox I'm inclined to merge this one now ready for our next release. It's, in fact, only a case change of our know fake product uuids and nothing more, and so makes not functional change to an existing systems Appliance ID: on re-install given the same hardware. That's was important. We also now have Appman so the case change from 3 to 4 is not a show stopper. And we might indicate this requirement within the activation code dialog (which already now links to Appman); but I see this as a related but independent issue to what is addressed in this pull request. |
|
Sounds good! Sorry for not getting to it; I got distracted by our other matters at hand. |
phillxnet
deleted the
2290_Fake_Product_UUID_Case_Sensitivity_Incorrect_on_Rockstor_4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Rockstor 4 is associated with newer kernel versions by default, which in turn now produce lowercase product uuid's, we fail in some cases to match against our mixed case tuple of know fake product uuids.
Fixes #2290
@FroggyFlox Ready for review.
Fix by normalising on lowercase in line with the sited uuid standard of: rfc4122 as per the kernel.
Includes formatting clean-ups of the known fake product uuids.
N.B. no functional change is made to how an existing install, of the same major version, generates it's Appliance ID.