Improve Web-UI update re systemd service management #2651 #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove dysfunctional and out-of-place systemd stop command. - Remove out-of-place Python bytecode (*.pyc) file deletion mechanism. Both of the above update elements would be more appropriately managed by zypper/rpm. With the latter having dubious utility; and potentially negative ramifications.
This was referenced Aug 15, 2023
|
See partner issue's pull request: rockstor/rockstor-rpmbuild#44 comments for proof of concept testing. |
phillxnet
deleted the
2651-Improve-Web-UI-update-re-systemd-service-management
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of the above update elements would be more appropriately managed by zypper/rpm. With the latter having dubious utility; and potentially negative ramifications.
Fixes #2651
Partnered with/related to: rockstor/rockstor-rpmbuild#43