Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(t) Update django-pipeline to 1.7.0 #2646 #2659

Conversation

FroggyFlox
Copy link
Member

Fixes #2646
@phillxnet , @Hooverdan96: ready for review.

This pull request simply proposes to update django-pipeline from 1.6.9 to 1.7.0.
See #2646 for rationale.

Note: Poetry automatically updated the certifi package to its latest version: 2023.7.22.

Testing

This branch was deployed to a 15.4 and a 15.5 VM with their /opt/rockstor folder wiped, and then rockstor was successfully built from source. I then browsed through various pages in the webUI and all loaded successfully without any "file not found" error.

Furthermore, all unit tests pass (ran on Leap 15.5):

buildvm155:/opt/rockstor # cd src/rockstor/ && /root/.local/bin/poetry run django-admin test ; cd -
Creating test database for alias 'default'...
Creating test database for alias 'smart_manager'...
System check identified no issues (0 silenced).
......................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 262 tests in 13.363s

OK
Destroying test database for alias 'default'...
Destroying test database for alias 'smart_manager'...
/opt/rockstor

@FroggyFlox FroggyFlox linked an issue Aug 17, 2023 that may be closed by this pull request
@Hooverdan96
Copy link
Member

seems to me a safe thing to do.

@phillxnet phillxnet merged commit b4aa4e1 into rockstor:testing Aug 18, 2023
@phillxnet
Copy link
Member

@FroggyFlox Thanks for seeing to these two issues; as always much appreciated.

@Hooverdan96 Cheers for the review here. Also much appreciated. I've merged with not further testing as this does seem pretty safe and we are in testing branch/channel still so this should be going out with our next release there.

@FroggyFlox FroggyFlox deleted the 2646-Outdated-version-for-django-pipeline branch August 19, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(t) Outdated version for django-pipeline
3 participants