Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(t) replication spawn error #2766 #2777

Merged

Commits on Jan 15, 2024

  1. (t) replication spawn error rockstor#2766

    Update replication code re Py2.7 to Py3.11.
    - Modernise previously missed replication imports re Py3.*
    - Force bytes format for replication messages and commands.
    Zmq requires bytes format.
    - Minor modification re Pythnon 3 behaviour re dict.keys(),
    we previously relied on an implicit Python 2 behaviour.
    - Move to Fstrings for all issue focused files.
    - Parameter/return type hinting.
    - Removed an unused local variable.
    - black format update
    - Improve error diagnostic content of receiver failing to
    retrieve senders IP address from sent appliance ID.
    - Improve debug logging.
    - Remove receiver 'latest_snap or b""' argument to improve
    readability.
    - reduce retry iterations from 10 to 3.
    - Remove use of None from within zmq command/message passing:
    to help with stricter type hinting.
    - remove libzmq socker.set_hwm.
    - refactor poll -> poller socks -> events for readability.
    - additional explanatory comments re sockets etc.
    - Enable tracker on listender_broker, sender, and receiver's
    response: improves robustness, and aids in debugging.
    - add zmq_version and libzmq_version properties to sender and
    receiver.
    - adapt iostream behaviour: this differs between Py2.7 & Py3.*.
    - Fix existing bug re very low send byte count.
    - harmonize on btrfs binary location to fs.btrfs for replication.
    - readability refactoring improvements.
    - keep receiver self.share/snap naming as str, encode before
    send only.
    - Avoid logging btrfs data stream contents.
    - Set read1() bytes read to 100MB max.
    phillxnet committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    795133c View commit details
    Browse the repository at this point in the history