Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From 4.1.0-0 stable release, the new testing branch is default for contributions. #357

Closed
phillxnet opened this issue Jan 20, 2022 · 0 comments · Fixed by #402
Closed

From 4.1.0-0 stable release, the new testing branch is default for contributions. #357

phillxnet opened this issue Jan 20, 2022 · 0 comments · Fixed by #402
Assignees

Comments

@phillxnet
Copy link
Member

phillxnet commented Jan 20, 2022

Our current developer on-boarding docs mention only the master branch. As from our recent 4.1.0-0 stable git tag rpm release we are now to develop our testing channel rpms from a newly established testing branch within git. The master branch is now reserved for our stable releases and so our docs should reflect this new split.

The new split to branch based development is to enable the massive code wide changes that are required for our pending Language and tools wide upgrade. E.g.:
rockstor/rockstor-core#1877
and it's indicated, in-development, sub-part dependency of:
rockstor/rockstor-core#2254

This 'movement' within the project should also be made clear on the developers page so that folks can choose where they think their contributions are to be submitted. But in almost all cases all code submissions will now go to our testing branch first. Cherry picking may then take place but the projects main focus is now to lift our dependencies across the board and move testing towards the next stable but via newer Python and django and associated libraries. The following issue in an example of this efforts beginning by moving what was one of our oldest dependencies ztaskd to be replaced by one one of our newest:

rockstor/rockstor-core#2283

However such 'up-lift' is nigh on impossible until we approach first our Django up-lift and then our Python up-lift. Which in turn will allow for a further Django upgrade and we can then approach the remaining dependencies piecemeal; including our now in need of some attention build system.

The above details should at least be indicated to new contributors to provide context. But in short all new contributions hit testing first and only long time contributors should be contributing directly to master give it's essentially a stop-gap to maintain a usable build as we undertake much needed maintenance work.

It should also be noted that testing is again soon to be non-functional as there is soon to be the contribution of ongoing Django updates that are extensive and will have breaking changes that are to be addressed in an ongoing manner in the new testing channel.

@phillxnet phillxnet self-assigned this Sep 11, 2022
@phillxnet phillxnet changed the title As from 4.1.0-0 stable release, the new testing branch is default for contributions. From 4.1.0-0 stable release, the new testing branch is default for contributions. Sep 11, 2022
phillxnet added a commit to phillxnet/rockstor-doc that referenced this issue Sep 11, 2022
As from git tag 4.1.0-0 we have begun extensive dependency update
work in a new testing branch. Make this clear in developer docs
and alter guidelines/instructions accordingly.
phillxnet added a commit that referenced this issue Sep 11, 2022
…e,_the_new_testing_branch_is_default_for_contributions

Note testing branch as preferred for core contributions #357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant