Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note testing branch as preferred for core contributions #357 #402

Conversation

phillxnet
Copy link
Member

@phillxnet phillxnet commented Sep 11, 2022

As from git tag 4.1.0-0 we have begun extensive dependency update work in a new testing branch. Make this clear in developer docs and alter guidelines/instructions accordingly.

Fixes #357

Additionally includes

  • minor typo fixes
  • fix for malformed/mis-configured forum link

Checklist

  • With the proposed changes no Sphinx errors or warnings are generated.
  • I have added my name to the AUTHORS file, if required (descending alphabetical order).

As from git tag 4.1.0-0 we have begun extensive dependency update
work in a new testing branch. Make this clear in developer docs
and alter guidelines/instructions accordingly.
@phillxnet
Copy link
Member Author

@FroggyFlox If you have time, could you give these changes a quick glance over, just in case. I've kept the changes minimal here which I think is the way to go. From experience we mostly have already had contact with folks embarking on this endeavour so we really only need a concise guide here; hence avoiding a lot of background info with these additions.

In time we will need additional sections to address new build systems we hope to bring in but that is for another issue/pull-request set as and when.

@FroggyFlox
Copy link
Member

That looks good to me, and a good addition!
I only have time for a quick look at it for the moment but it's indeed an important addition.

Thanks a lot for taking care of it!

@phillxnet
Copy link
Member Author

@FroggyFlox Cheers and agreed. I'll merge and publish.

@phillxnet phillxnet merged commit 3beeeca into rockstor:master Sep 11, 2022
@phillxnet phillxnet deleted the 357_From_4.1.0-0_stable_release,_the_new_testing_branch_is_default_for_contributions branch September 11, 2022 16:48
@phillxnet
Copy link
Member Author

Patch product production published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

From 4.1.0-0 stable release, the new testing branch is default for contributions.
2 participants