Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build micro and init variants of the container images #42

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

lumarel
Copy link
Collaborator

@lumarel lumarel commented Apr 2, 2023

There are still some TODOs left:

  • Make sure that the UBI images are built very similar to the upstream images, and then removing the systemd install in the init container, related PRs are available here and here

If any changes/improvements are wanted, sure I can take them in account!
Testbuilds are available here: https://quay.io/repository/lumarel/rockylinux?tab=tags

Copy link
Member

@NeilHanlon NeilHanlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NeilHanlon
Copy link
Member

@lumarel do you want me to merge this and we can work on the other repo pushing (or maybe setting up syncing, instead?) later?

@lumarel
Copy link
Collaborator Author

lumarel commented Apr 7, 2023

@NeilHanlon I already had it planned out, now it is possible to create DOCKER_USERNAME, DOCKER_TOKEN, QUAY_USERNAME and QUAY_TOKEN, and easily push to them :)
And if we need more it's very easy to add.

Also Added a CI pipeline now for these images.

So yeah I think it's ready to merge, and when we are done with the changes in the kickstart repo and generated new images, we can also remove the systemd line in the init container, but that can be done later 👍🏻

@lumarel lumarel requested a review from NeilHanlon April 7, 2023 11:34
@NeilHanlon NeilHanlon merged commit a43b9a4 into rocky-linux:main Apr 7, 2023
@lumarel lumarel deleted the feature/build-2nd-layer branch April 7, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants