feature/truncate clean up method #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkorobkov
reviewed
Aug 28, 2017
|
|
||
| @Override | ||
| public void accept(InstructionVisitor visitor) { | ||
| visitor.visit(this); | ||
| visitor.visit(this, this.cleanMethod); |
There was a problem hiding this comment.
If you pass this - why do you need to pass this.cleanMethod?
vkorobkov
reviewed
Aug 28, 2017
| log.info("Processing table '" + tableName + "'"); | ||
| List<Instruction> fixtureInstructions = new ArrayList<>(); | ||
|
|
||
| fixtureInstructions.addAll(table.getBeforeCleanup().stream() | ||
| .map(s -> customSql(tableName, s)).collect(Collectors.toList())); | ||
|
|
||
| if (CleanMethod.DELETE == table.getCleanMethod()) { | ||
| fixtureInstructions.add(cleanupTable(fixture)); | ||
| if (CleanMethod.DELETE == cleanMethod || CleanMethod.TRUNCATE == cleanMethod) { |
There was a problem hiding this comment.
if (cleanMethod != CleanMethod.NONE) { ?
vkorobkov
reviewed
Aug 28, 2017
| @@ -65,8 +67,8 @@ private void handleFixtureInstructions(Fixture fixture) { | |||
| context.getInstructions().addAll(fixtureInstructions); | |||
| } | |||
|
|
|||
| private Instruction cleanupTable(Fixture fixture) { | |||
| return new CleanTable(fixture.name); | |||
| private Instruction cleanupTable(Fixture fixture, CleanMethod cleanMethod) { | |||
There was a problem hiding this comment.
Maybe it makes sense to "inline" this method?
vkorobkov
reviewed
Aug 28, 2017
| val table = escapeTableOrColumn(cleanTable.getTable()); | ||
| val cleanMethod = cleanTable.getCleanMethod(); | ||
|
|
||
| if (CleanMethod.DELETE == cleanMethod) { |
There was a problem hiding this comment.
Expand to switch/case with throwing IllegalStateException in default branch?
vkorobkov
reviewed
Aug 28, 2017
| if (CleanMethod.DELETE == table.getCleanMethod()) { | ||
| fixtureInstructions.add(cleanupTable(fixture)); | ||
| if (CleanMethod.DELETE == cleanMethod || CleanMethod.TRUNCATE == cleanMethod) { | ||
| fixtureInstructions.add(cleanupTable(fixture, table.getCleanMethod())); |
There was a problem hiding this comment.
What do you think if we always add a CleanupTable instruction even when the CleanMethod is NONE? But in case of NONE the instruction won't add any SQL
|
How does integration with slack work? |
|
Integration test 2 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.