Librarian-puppet package seems to get into an infinite loop #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossg
added a commit
that referenced
this pull request
Feb 7, 2014
Librarian-puppet package seems to get into an infinite loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just started looking into librarian-puppet on CentOS 6, Ruby 1.8.7, and it appears that when running librarian-puppet package it gets into an infinite loop when fetching from puppetforge. I'm fairly new to ruby, but the bit of code it seems to be tripping up on is in lib/librarian/puppet/source/forge.rb, in the vendor_cache function. The while loop which loops over input.read never finishes, as it would seem that without a length argument it returns the whole file each time. This only happens when calling package, install works fine.