String containing escape char (and no var) incorrectly flagged

[phrawzty]

Hello again,

Consider :

class t {
    $alpha = 'foo\n'
    $delta = "bar\n"               # line 3
}

Will result in :
WARNING: double quoted string containing no variables on line 3

I've never used the Puppet Lexer, so I'm totally in the dark as to whether it can be leveraged to deal with this or not; once I get a chance to look at it I'll submit a patch, but if you have a solution, then go for it. ;)

[rodjek]

Yeah, this is a use case overlooked by the style guide, but still valid. It's an easy fix, I'll take care of it in a bit.

On 09/09/2011, at 8:48 PM, danreply@reply.github.com wrote:

Hello again,

Consider :

class t {
   $alpha = 'foo\n'
   $delta = "bar\n"               # line 3
}

Will result in :
WARNING: double quoted string containing no variables on line 3

I've never used the Puppet Lexer, so I'm totally in the dark as to whether it can be leveraged to deal with this or not; once I get a chance to look at it I'll submit a patch, but if you have a solution, then go for it. ;)

Reply to this email directly or view it on GitHub:
#26