Skip to content

Commit

Permalink
(maint) Bump version to 2.0.0 for release
Browse files Browse the repository at this point in the history
This patch bumps the version of rspec-puppet to 2.0.0.  A new major
version is warranted because of the following changes noted by Joshua
Hoblitt.

There were several small bits of breakage and most (all?) of my modules
required forward porting work.

Some tests still had include_class, which I believe was long deprecated
anyways.

 * I ended up pinning the version of rspec-core as gem 'rspec-core', '~> 2.0'
   to silence rspec 3 warnings. It would be nice if a new release set this
   requirement it it's gemspec.

 * It looks like libdir handling changes broke rspec-puppet-augeas
   domcleal/rspec-puppet-augeas#15

 * All instances of verify_contents(subject, ...) broke as subject has been
   removed and replaced with catalogue. #235

 * The construct I had been using to check for exceptions in negative tests
   broke. expect { should }.to raise_error(...) had to be replaced with should
   raise_error(...)

The last 2-3 are definitely breaking changes from 1.0.0 and I believe this
warrants a major version bump. Otherwise, I expect 'rspec-puppet', '~> 1.0'
will still break a number of module's tests.
  • Loading branch information
Jeff McCune committed Dec 2, 2014
1 parent 3c889a4 commit 8459e14
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rspec-puppet.gemspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Gem::Specification.new do |s|
s.name = 'rspec-puppet'
s.version = '1.0.1'
s.version = '2.0.0'
s.homepage = 'https://github.com/rodjek/rspec-puppet/'
s.summary = 'RSpec tests for your Puppet manifests'
s.description = 'RSpec tests for your Puppet manifests'
Expand Down

0 comments on commit 8459e14

Please sign in to comment.