Fix naming of test_api specs so they run

Incorrectly named ever since they were added 7dddebd, updated to take
into account the change of `subject` in 34220fc and rspec should/expect
style changes.

spec/classes/test_api.rb → spec/classes/test_api_spec.rb

@@ -3,18 +3,18 @@
 describe 'test::bare_class' do
   describe 'rspec group' do
     it 'should have a catalogue method' do
-      catalogue.should be_a(Puppet::Resource::Catalog)
+      expect(catalogue).to be_a(Puppet::Resource::Catalog)
     end
 
     it 'subject should return a catalogue' do
-      subject.should be_a(Puppet::Resource::Catalog)
+      expect(subject.call).to be_a(Puppet::Resource::Catalog)
     end
 
     describe 'derivative group' do
       subject { catalogue.resource('Notify', 'foo') }
 
       it 'can redefine subject' do
-        subject.should be_a(Puppet::Resource)
+        expect(subject).to be_a(Puppet::Resource)
       end
     end
   end

spec/defines/test_api.rb → spec/defines/test_api_spec.rb

@@ -6,11 +6,11 @@
 
   describe 'rspec group' do
     it 'should have a catalogue method' do
-      catalogue.should be_a(Puppet::Resource::Catalog)
+      expect(catalogue).to be_a(Puppet::Resource::Catalog)
     end
 
     it 'subject should return a catalogue' do
-      subject.should be_a(Puppet::Resource::Catalog)
+      expect(subject.call).to be_a(Puppet::Resource::Catalog)
     end
   end
 end

spec/hosts/test_api.rb → spec/hosts/test_api_spec.rb

@@ -3,11 +3,11 @@
 describe 'foo.example.com' do
   describe 'rspec group' do
     it 'should have a catalogue method' do
-      catalogue.should be_a(Puppet::Resource::Catalog)
+      expect(catalogue).to be_a(Puppet::Resource::Catalog)
     end
 
     it 'subject should return a catalogue' do
-      subject.should be_a(Puppet::Resource::Catalog)
+      expect(subject.call).to be_a(Puppet::Resource::Catalog)
     end
   end
 end