New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement History endpoint #39

Closed

invacuo opened this issue Oct 13, 2018 · 1 comment · Fixed by #45

Labels

Collaborator

invacuo commented Oct 13, 2018

https://documenter.getpostman.com/view/2025350/RWaEzAiG#ead57e9b-70db-432d-9923-4bf4b881cfd0

Collaborator Author

invacuo commented Oct 13, 2018

I would like to take this on.

rodolfobandeira added the in progress label

invacuo mentioned this issue

More refactoring #41

Merged

invacuo added a commit to invacuo/spacex that referenced this issue


          Add a history endpoint

163aa69

This is a very basic history endpoint as described in the issue rodolfobandeira#39

This doesn't support all the filters that are described in the
documentation provided here
https://documenter.getpostman.com/view/2025350/RWaEzAiG#9f1dfdc0-fbe8-4ae5-9209-7f3d649a627c
but it does support the basic functionality of retrieving all the
historical events or a specific historical event by passing an id

invacuo mentioned this issue

Add a history endpoint #45

Merged

invacuo added a commit to invacuo/spacex that referenced this issue


          Add a history endpoint

4d331b4

- A very basic history endpoint as described in the issue rodolfobandeira#39
- Doesn't yet support all the filters that are described in the documentation provided here https://documenter.getpostman.com/view/2025350/RWaEzAiG#9f1dfdc0-fbe8-4ae5-9209-7f3d649a627c
- Allows retrieving all the historical events or a specific historical event by passing an id
- This closes rodolfobandeira#39 when merged in.

Notes:
- Also decided to alphabetize the order in which we `require` the files in the `spacex.rb` file

invacuo added a commit to invacuo/spacex that referenced this issue


          Add a history endpoint

401c11f

- A very basic history endpoint as described in the issue rodolfobandeira#39
- Doesn't yet support all the filters that are described in the documentation provided here https://documenter.getpostman.com/view/2025350/RWaEzAiG#9f1dfdc0-fbe8-4ae5-9209-7f3d649a627c
- Allows retrieving all the historical events or a specific historical event by passing an id
- This closes rodolfobandeira#39 when merged in.

Notes:
- Also decided to alphabetize the order in which we `require` the files in the `spacex.rb` file

invacuo closed this as completed in #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment