-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow for mlflow added #74
Conversation
6d0ff6b
to
9d98387
Compare
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
===========================================
- Coverage 100.00% 93.25% -6.75%
===========================================
Files 19 19
Lines 727 727
===========================================
- Hits 727 678 -49
- Misses 0 49 +49
Continue to review full report at Codecov.
|
5cb9baf
to
272551f
Compare
Hi, I think is a good idea, there are a couple things I'd to comment:
|
Hey, yeah you're absolutely right. I'll remove the cleanup and I think I'll use testcontainers to get the server port, there's a compose class that'll actually run the compose.yml for us, which is nice. No worries! |
90b3ec5
to
50f7d29
Compare
50f7d29
to
1de2dd4
Compare
Ey thanks, I see now the tests pass, whici is great! I just have to check why the test coverage is decreasing Sorry for the delayed answer, I was a bit far away a couple weeks |
relative imports to avoid mix with installed package
Closing for now as test have been successful without docker, just to keep dependencies and test as simple as possible |
I think I might have a solution for MLflow finally. I've been working with docker quite a bit lately so I think this might work. Tell me what you think.