Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for header middleware #57

Merged
merged 4 commits into from
Oct 13, 2020

Conversation

Ashwithabg
Copy link
Contributor

@Ashwithabg Ashwithabg commented Oct 13, 2020

#45

Co-authored-by: Ravi ravikumarkarn080@gmail.com

Co-authored-by: Ravi <ravikumarkarn080@gmail.com>
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #57 into master will decrease coverage by 1.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   75.40%   74.27%   -1.13%     
==========================================
  Files           7        9       +2     
  Lines         187      206      +19     
==========================================
+ Hits          141      153      +12     
- Misses         44       51       +7     
  Partials        2        2              
Flag Coverage Δ
#unittests 74.27% <ø> (-1.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
model/node.go 94.66% <0.00%> (ø)
utils/utils.go
handle/middlewares/cors.go 0.00% <0.00%> (ø)
lib/file/utils.go 100.00% <0.00%> (ø)
handle/middlewares/headers.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5b96f9...bc2f9d0. Read the comment docs.

Copy link
Owner

@rodrigo-brito rodrigo-brito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Ashwithabg, thank you for you contribution

handle/middlewares/headers.go Outdated Show resolved Hide resolved
@rodrigo-brito
Copy link
Owner

It looks great! Thank you for your contribution!

@rodrigo-brito rodrigo-brito merged commit ab79107 into rodrigo-brito:master Oct 13, 2020
@Ashwithabg
Copy link
Contributor Author

Thanks @rodrigo-brito
It was a good learning for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants