Using tmp dir instead of GOPATH #72
Conversation
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
+ Coverage 97.00% 97.01% +0.01%
==========================================
Files 8 8
Lines 200 201 +1
==========================================
+ Hits 194 195 +1
Misses 4 4
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rafaelsq
changed the title
rafaelsq
force-pushed
the
fixGopath
branch
2 times, most recently
from
2b8ab36
to
a6136fa
Compare
| } | ||
| for _, tt := range tests { | ||
| t.Run(fmt.Sprintf("given project %s/%s", tt.path, tt.repository), func(t *testing.T) { | ||
| got := TrimGoPath(tt.path, tt.repository) |
There was a problem hiding this comment.
TrimGoPath?, maybe a rename to TrimTemporaryPath will be great
main.go
Outdated
| tmpFolder, err := ioutil.TempDir("", "") | ||
| if err != nil { | ||
| log.Fatal(err) | ||
| } |
There was a problem hiding this comment.
Please, use os.TempDir https://pkg.go.dev/os#TempDir
There was a problem hiding this comment.
not available for the current Go version. I had to fallback to ioutil 😞
There was a problem hiding this comment.
ioutil is deprecated: https://golang.org/doc/go1.16#ioutil
lib/fetch_test.go
Outdated
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestFetch(t *testing.T) { | ||
| f := NewFetcher() | ||
| tmpFolder, _ := ioutil.TempDir("", "") |
There was a problem hiding this comment.
Please, change to os.TempDir: https://pkg.go.dev/os#TempDir
No description provided.