Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSServer -m map path parameter #45

Merged
merged 5 commits into from
Mar 2, 2021
Merged

GSServer -m map path parameter #45

merged 5 commits into from
Mar 2, 2021

Conversation

WAEliasmith
Copy link
Contributor

@WAEliasmith WAEliasmith commented Mar 1, 2021

added -m parameter

Testing:
With parameter:
`
python3.8 /home/ae/anm_unreal_sim/submodules/geoscenarioserver/GSServer.py --scenario /home/ae/anm_unreal_test_suite/scenarios/ring_road_ccw/geoscenarioserver/ring_road_ccw.osm --map-path /home/ae/anm_unreal_test_suite/maps

*GSS server runs with 10 updating VIDS
Without parameter:
python3.8 /home/ae/anm_unreal_sim/submodules/geoscenarioserver/GSServer.py --scenario /home/ae/anm_unreal_test_suite/scenarios/ring_road_ccw/geoscenarioserver/ring_road_ccw.osm

RuntimeError: Could not find lanelet map under /home/ae/anm_unreal_sim/submodules/geoscenarioserver/scenarios/ring_road/lanelet2/ringroad.osm
`
These files aren't implemented here yet, so this makes sense.

@WAEliasmith WAEliasmith changed the title GSServer -m map path parameter GSServer -m map path parameter WIP Mar 1, 2021
@WAEliasmith WAEliasmith changed the title GSServer -m map path parameter WIP GSServer -m map path parameter Mar 1, 2021
@mantkiew mantkiew self-requested a review March 2, 2021 15:49
Copy link
Collaborator

@mantkiew mantkiew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with and without the --map-path parameter. Both cases work.

@WAEliasmith WAEliasmith merged commit 34d9d0c into master Mar 2, 2021
@mantkiew mantkiew deleted the map_path_parameter branch March 2, 2021 15:58
@WAEliasmith
Copy link
Contributor Author

Tests from above, in case you missed them:
With parameter:
`
python3.8 /home/ae/anm_unreal_sim/submodules/geoscenarioserver/GSServer.py --scenario /home/ae/anm_unreal_test_suite/scenarios/ring_road_ccw/geoscenarioserver/ring_road_ccw.osm --map-path /home/ae/anm_unreal_test_suite/maps

*GSS server runs with 10 updating VIDS
Without parameter:
python3.8 /home/ae/anm_unreal_sim/submodules/geoscenarioserver/GSServer.py --scenario /home/ae/anm_unreal_test_suite/scenarios/ring_road_ccw/geoscenarioserver/ring_road_ccw.osm

RuntimeError: Could not find lanelet map under /home/ae/anm_unreal_sim/submodules/geoscenarioserver/scenarios/ring_road/lanelet2/ringroad.osm
`
These files aren't implemented here yet, so this makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants