Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fixes: PDFfolder.png, SDKROOT, formatting. #2

Merged
merged 1 commit into from
May 4, 2020

Conversation

mckenfra
Copy link
Contributor

@mckenfra mckenfra commented May 4, 2020

This PDF printer driver works great, thanks a lot! I've made a few fixes to buildscript.sh, as it was generating the following errors when run on macOS High Sierra (may also affect other OS versions):

ld: warning: text-based stub file /System/Library/Frameworks//appkit.framework/appkit.tbd and library file /System/Library/Frameworks//appkit.framework/appkit are out of sync. Falling back to library file for linking.
ld: warning: text-based stub file /System/Library/Frameworks//Foundation.framework/Foundation.tbd and library file /System/Library/Frameworks//Foundation.framework/Foundation are out of sync. Falling back to library file for linking.
[...repeated many times...]

cp: PDFfolder.png: No such file or directory

Also, the text in the package installation screen looked a bit cramped, so I spaced it out better and formatted the code blocks better too:

Current Version (has some spacing / formatting issues)

PDFWriter-Old1

PDFWriter-Old2

New Version (improved spacing & code blocks)

PDFWriter-New1

PDFWriter-New2

Thanks a lot!

Francis

Copy link
Owner

@rodyager rodyager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Francis.

This is much appreciated.

Rod

@rodyager rodyager merged commit 98c2605 into rodyager:master May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants