Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win does not handle : correctly #100

Closed
joanise opened this issue Apr 9, 2021 · 0 comments · Fixed by #168
Closed

win does not handle : correctly #100

joanise opened this issue Apr 9, 2021 · 0 comments · Fixed by #168

Comments

@joanise
Copy link
Collaborator

joanise commented Apr 9, 2021

  1. The win g2p outputs ascii : instead of \u02D0, which is the correct IPA symbol for length markers.

  2. The win-ipa to eng-ipa mapping sometimes doubles them up. All the lengthened vowels needs to be reviewed.

e.g.:

$ g2p convert "ō" win eng-arpabet
OW ː
$ g2p convert "ee" win eng-arpabet
EY ː
  1. There is no public/data/win.* test suite to validate that g2p works correctly on this language.
joanise added a commit that referenced this issue Jun 16, 2022
@joanise
fix(win): use the \u02D0, not :; use prevent-feeding
8d13c21 
The length marker in IPA is ː (\u02D0), not : (ascii colon)

win-ipa to eng-ipa had a feeding problem, with "eː"->"eː" feeding
"e"->"eː" and thus generating "eːː" in the eng-ipa output, and "EY ː" in
the eng-arpabet output.

Unit tests added for individual characters, but I have no words to test
properly, so I'm doing the best I can with what I have...

FIXES #100
@joanise joanise mentioned this issue Jun 16, 2022
Merged
roedoejet pushed a commit that referenced this issue Jun 16, 2022
@joanise @roedoejet
fix(win): use the \u02D0, not :; use prevent-feeding
80f80da 
The length marker in IPA is ː (\u02D0), not : (ascii colon)

win-ipa to eng-ipa had a feeding problem, with "eː"->"eː" feeding
"e"->"eː" and thus generating "eːː" in the eng-ipa output, and "EY ː" in
the eng-arpabet output.

Unit tests added for individual characters, but I have no words to test
properly, so I'm doing the best I can with what I have...

FIXES #100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix win mapping with right length marker and avoid doubling it roedoejet/g2p
1 participant
@joanise