Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

progressBar doesn't check for 0 input #17

Closed
wenkokke opened this issue Jul 3, 2017 · 2 comments
Closed

progressBar doesn't check for 0 input #17

wenkokke opened this issue Jul 3, 2017 · 2 comments
Labels
bug

Comments

@wenkokke
Copy link

wenkokke commented Jul 3, 2017

The library doesn't check for 0 input for the "amount of work done", meaning that if you call any of the progressBar functions with 0 as the 4th argument:

progressBar prefLbl postLbl windowHeight workDone workTotal

You get a nice prefLbl [exe: Ratio has zero denominator error.
@wenkokke wenkokke changed the title Doesn't check for 0 input progressBar doesn't check for 0 input Jul 3, 2017
@wenkokke wenkokke changed the title progressBar doesn't check for 0 input progressBar doesn't check for 0 input Jul 3, 2017
@roelvandijk roelvandijk added the bug label Jul 8, 2017
@roelvandijk
Copy link
Owner

That should definitely be fixed. Thanks for the report!

roelvandijk added a commit that referenced this issue Jul 8, 2017
@roelvandijk
Fixes issue #17 in percentage label with todo == 0
87ea311 
Also added a test case for this scenario.
@roelvandijk
Copy link
Owner

roelvandijk commented Jul 8, 2017 •
edited
Loading

The problem was in the percentage label function. It is now fixed and a regression test was added. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roelvandijk @wenkokke