take_real_or_not no longer necessary
#46
Conversation
The issue from zygote that made this necessary is closed now.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 92.13% 91.30% -0.84%
==========================================
Files 14 14
Lines 623 621 -2
==========================================
- Hits 574 567 -7
- Misses 49 54 +5
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| function deconvolution(measured::AbstractArray{T, N}, psf; | ||
| loss=Poisson(), | ||
| regularizer=GR(), | ||
| λ=T(0.05), | ||
| background=zero(T), | ||
| mapping=Non_negative(), | ||
| iterations=nothing, | ||
| conv_dims = ntuple(+, ndims(psf)), | ||
| padding=0.00, | ||
| opt_options=nothing, | ||
| opt=LBFGS(linesearch=BackTracking()), | ||
| initial=mean(measured), | ||
| debug_f=nothing, | ||
| opt_package=Opt_Optim) where {T, N} | ||
| function deconvolution(measured::AbstractArray{T,N}, psf; | ||
| loss=Poisson(), | ||
| regularizer=GR(), | ||
| λ=T(0.05), | ||
| background=zero(T), | ||
| mapping=Non_negative(), | ||
| iterations=nothing, | ||
| conv_dims=ntuple(+, ndims(psf)), | ||
| padding=0.00, | ||
| opt_options=nothing, | ||
| opt=LBFGS(linesearch=BackTracking()), | ||
| initial=mean(measured), | ||
| debug_f=nothing, | ||
| opt_package=Opt_Optim) where {T,N} |
There was a problem hiding this comment.
can you maybe revert this again?
There was a problem hiding this comment.
I truly do not know, how is this happening... I must have some kind of hook set up pre-push because I do not have these locally.. Can you think of a reason, why this keeps happening? I will revert those.
There was a problem hiding this comment.
Isn't that your editor?
Maybe your master branch is not synced with upstream anymore
There was a problem hiding this comment.
I think this was because I had the wrong repo set as the default one. I created a new PR.
take_real_or_notnot necessary