-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to vue 3 #91
Open
bkjohnson
wants to merge
11
commits into
rogden:master
Choose a base branch
from
bkjohnson:upgrade-vue
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upgrade to vue 3 #91
Commits on Jan 21, 2024
-
This is following the instructions at [this article][1]. I removed vue-intersect because it wasn't compatible with vue3 - I may go back and figure something out. [1]: https://vueschool.io/articles/vuejs-tutorials/how-to-migrate-from-vue-cli-to-vite/
Configuration menu - View commit details
-
Copy full SHA for 84906e2 - Browse repository at this point
Copy the full SHA 84906e2View commit details -
There is still a Proxy client side that I think is causing problems
Configuration menu - View commit details
-
Copy full SHA for a71a277 - Browse repository at this point
Copy the full SHA a71a277View commit details -
Properly mount each canvas section components
I couldn't figure out how to get vue to work with the async dynamic import so I created the index file instead. There is a problem with the Transitions component which I will try to fix next
Configuration menu - View commit details
-
Copy full SHA for 00447c2 - Browse repository at this point
Copy the full SHA 00447c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00ec0d1 - Browse repository at this point
Copy the full SHA 00ec0d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ac5d09 - Browse repository at this point
Copy the full SHA 5ac5d09View commit details
Commits on Jan 22, 2024
-
This just leverages the vite dev server to be very similar to the `dev` npm script. I used `yarn link` to test it with another local package and found that I needed to use some absolute paths to ensure that the right config got used. Next will be a similar treatment for the export command.
Configuration menu - View commit details
-
Copy full SHA for 6472225 - Browse repository at this point
Copy the full SHA 6472225View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68bea06 - Browse repository at this point
Copy the full SHA 68bea06View commit details -
Configuration menu - View commit details
-
Copy full SHA for cff1690 - Browse repository at this point
Copy the full SHA cff1690View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2844273 - Browse repository at this point
Copy the full SHA 2844273View commit details -
I think we'll need to publish the src because vite is going to build it for the cli commands.
Configuration menu - View commit details
-
Copy full SHA for 5adbd39 - Browse repository at this point
Copy the full SHA 5adbd39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18db591 - Browse repository at this point
Copy the full SHA 18db591View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.