Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version numbering scheme #340

Closed
rogerbinns opened this issue Jun 11, 2022 · 1 comment
Closed

Update version numbering scheme #340

rogerbinns opened this issue Jun 11, 2022 · 1 comment
Assignees
@rogerbinns

Comments

@rogerbinns
Copy link
Owner

rogerbinns commented Jun 11, 2022 •
edited

It is currently SQLITEVERSION-rAPSWREV. There are several problems:

  • -r clashes with gentoo
  • msi doesn't want any non-numeric parts
  • setuptools doesn't like non-numeric parts, with carve outs for 'alpha', 'beta' etc but not -r
  • the distutils included in setuptools has its own complaints
  • setup.py tries to mangle the version number in places to meet the rules

This approach was originally taken because SQLite used variable version numbers - 3.8.11.1. Since 3.9 it has stuck to semver so we only need to worry about 3 parts, and can use a 4th part for the apsw revision.
@rogerbinns rogerbinns self-assigned this Jun 11, 2022
rogerbinns added a commit that referenced this issue Jul 6, 2022
@rogerbinns
Switch version numbering scheme
72404c9 
See #340
rogerbinns added a commit that referenced this issue Jul 6, 2022
@rogerbinns
Remove building MSI
ec799c0 
It also disagrees with version numbering scheme #340
and we are in pypi
rogerbinns added a commit that referenced this issue Jul 7, 2022
@rogerbinns
Changelog version scheme change #340
81b9f7e
@rogerbinns
Copy link
Owner Author

This is now done

@cjrh cjrh mentioned this issue Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogerbinns rogerbinns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rogerbinns