Optimize Print::write(const char *str)

[vshymanskyy]

Arduino_STM32/STM32F1/cores/maple/Print.cpp

Line 49 in 596dc0d

size_t Print::write(const char *str) {

This should really call strlen() and then call Print::write(const void *buffer, uint32 size) implementation.
Why so? Because the write(buffer, size) is commonly overridden and implemented in an optimized manner (sending data to the wifi/gsm module in chunks, not byte by byte...).

[rogerclarkmelbourne]

Virtually nothing is bounds tested.

Adding bounds testing to such a low level function will considerably slow down its operation and break people's code, who rely on fast transfers

Please do your bounds checking before calling write

[vshymanskyy]

Well, virtually every library out there expects Arduino Core to behave this way ;)
I am not asking for bounds checks, I'm asking to call a different overloaded/overridden function.
Check out this:
https://github.com/arduino/Arduino/blob/master/hardware/arduino/avr/cores/arduino/Print.h#L52

[stevstrong]

I think that this would make sense, even if at the end some of the overloaded functions end up with the same single writes.
I would go further and move these functions in a header file as Arduino core does.

[victorpv]

Not sure if the call to strlen would increase the size, but I agree with OP and Steve that is better to use Print::write(const void *buffer, uint32 size), should remove a lot of overhead when sending a few characters at once.
@Steve, do you have a link to the relevant files in the Arduino code to see how it's done there?

[rogerclarkmelbourne]

Ah,

I thought you were proposing bounds checking.. My mistake...

[stevstrong]

Victor, take a look at the very first link of OP.

[rogerclarkmelbourne]

Fix is in commit

f56c37e

I will close this.,

Re-open if there is a problem

[vshymanskyy]

Thanks! BTW is it only related to F1 or tp other cores as well? Didn't check them

[rogerclarkmelbourne]

Good point, I should update the F4 and perhaps the F3

Note. The F3 is really not supported, there arent any F3 boards in the boards.txt, its just there as an archive, but I should probably remove it, because git will keep a record of it in the older commits

[rogerclarkmelbourne]

Fixed