Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FreeRTOS to prevent library conflict #500

Closed
bratoff opened this issue Apr 16, 2018 · 8 comments
Closed

Rename FreeRTOS to prevent library conflict #500

bratoff opened this issue Apr 16, 2018 · 8 comments

Comments

@bratoff
Copy link

bratoff commented Apr 16, 2018

Version 7.0.1 of FreeRTOS for STM32duino should be renamed from FreeRTOS to FreeRTOS701 so that it does not conflict with the mainstream version of FreeRTOS.

@rogerclarkmelbourne
Copy link
Owner

@victorpv
You are the FreeRTOS expert

Does this sound OK to you ?

@victorpv
Copy link
Contributor

Renaming it should be fine, and make it easier to see that's the 7.0.1 version (the oldest that we have).
I see no problem on that.

Now, I don't see where is the conflict with the mainstream version.
We have the 9.0.0 version in another folder called FreeRTOS 900.
@bratoff can you provide more detail on what conflict you are trying to avoid?

@bratoff
Copy link
Author

bratoff commented May 19, 2018

@victorpv - There appears to be a naming conflict with version 10.0.0-10 which causes that version to always show "needs update" when the STM32duino core is active. It must be the un-versioned FreeRTOS 7.0.1 causing it because the "needs update" goes away if a non-STM32duino board is selected. (I have about 8 different board families configured in my IDE.)

@victorpv
Copy link
Contributor

@bratoff a couple of questions:
Did you test renaming the 7.0.1 folder?
What IDE are you using?
Where did you get the FreeRTOS 10 library from?

@fpistm
Copy link
Contributor

fpistm commented May 21, 2018

@victorpv probably this one:
https://github.com/feilipu/Arduino_FreeRTOS_Library
But not applicable for STM32, anyway, I think his concern is about to have both libraries installed (one for AVR and one for STM32).
And the mainstream have the same name (name=FreeRTOS) than the one from Roger.
https://github.com/rogerclarkmelbourne/Arduino_STM32/tree/master/STM32F1/libraries/FreeRTOS
This causing issue with library updater as folder have the same name.
There is no issue at build time as include names are different.

@victorpv
Copy link
Contributor

I see no problem renaming the folder to FreeRTOS701, as you say what matters should be the include name anyway.

@fpistm
Copy link
Contributor

fpistm commented May 21, 2018

That's the point ;) Only rename the FrerRTOS folder to FreeRTOS701 ;)

@rogerclarkmelbourne
Copy link
Owner

Fixed in 6a551bd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants