bump Go, drop test-gotip, clean up code for old Go versions #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per rogpeppe#200, macos-12 can cause sporadic `signal: killed` testscript failures, and we have started seeing them in some jobs within go-internal itself as well. Downgrade to macos-11 for now, like we've done in other projects, as we still don't know the cause. Also drop test-gotip; we haven't been keeping it up to date for a while now, so it's clearly not needed at the moment. If we want to ensure that go-internal works on new major versions of Go before they are released, using the beta or RC releases seems like a better and easier approach.
While here, clean up code to support older versions of Go. Note that none of these changes should explicitly break Go 1.18.
rogpeppe
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit messages - please do not squash)
FYI @thepudds