Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump Go, drop test-gotip, clean up code for old Go versions #207

Merged
merged 2 commits into from
Mar 27, 2023
Merged

bump Go, drop test-gotip, clean up code for old Go versions #207

merged 2 commits into from
Mar 27, 2023

Commits on Mar 22, 2023

  1. CI: downgrade from macos-12, drop test-gotip 

    Per rogpeppe#200, macos-12 can cause sporadic `signal: killed` testscript
failures, and we have started seeing them in some jobs within
go-internal itself as well. Downgrade to macos-11 for now,
like we've done in other projects, as we still don't know the cause.

Also drop test-gotip; we haven't been keeping it up to date for a while
now, so it's clearly not needed at the moment. If we want to ensure that
go-internal works on new major versions of Go before they are released,
using the beta or RC releases seems like a better and easier approach.
    @mvdan
    mvdan committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    bee8416 View commit details
    Browse the repository at this point in the history

  2. add Go 1.20, drop 1.18 

    While here, clean up code to support older versions of Go.
Note that none of these changes should explicitly break Go 1.18.
    @mvdan
    mvdan committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    0bc8cc8 View commit details
    Browse the repository at this point in the history