Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use go/build to import the package and get the name #3

Closed
wants to merge 3 commits into from

Conversation

pepin
Copy link

@pepin pepin commented Feb 20, 2015

I was having trouble with this not resolving things, and it was because my code isn't always named according to the regex here.

With this change, godef works as expected for me.

@rogpeppe
Copy link
Owner

Thanks for the change. I'm not sure this is quite right though, as it always uses the default build context, which may not be right. I need to think about the right approach here a little more.

BTW please consider naming your package paths according to the convention - it makes code hard to read when the package path doesn't match the identifier that it declares.

@pepin
Copy link
Author

pepin commented Feb 23, 2015

Agreed. This made the tool work as expected for me. Feel free to use it or discard it. Thanks for writing this in the first place.

@zippoxer
Copy link

Solved the problem for me too. Thanks @pepin !

@pwaller
Copy link

pwaller commented Mar 31, 2016

This is one of those annoying things which makes godef sometimes not work. @rogpeppe any chance of getting a fix like this in?

@rogpeppe
Copy link
Owner

Superceded by #34.

@rogpeppe rogpeppe closed this May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants