always use correct package identifiers rather than guessing #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
rogpeppe
force-pushed
the
007-proper-import-names
branch
from
02131e7
to
cef1a4b
Compare
This will slow things down a little because we will always read the directories of the imports of a file when parsing, but hopefully won't make things *that* much slower.
rogpeppe
force-pushed
the
007-proper-import-names
branch
from
cef1a4b
to
99cc3e3
Compare
This was referenced May 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will slow things down a little because we will always read
the directories of the imports of a file when parsing, but
hopefully won't make things that much slower.