Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem version / GitHub Pages remote_theme support #59

Closed
2 tasks done
rohanchandra opened this issue Sep 17, 2017 · 8 comments
Closed
2 tasks done

Gem version / GitHub Pages remote_theme support #59

rohanchandra opened this issue Sep 17, 2017 · 8 comments

Comments

@rohanchandra
Copy link
Owner

rohanchandra commented Sep 17, 2017

The Type Theme gem and GitHub Pages remote_theme support is in development.

To use the remote theme:

  1. Create a new Jekyll site
  2. Add a key-value pair of remote_theme: rohanchandra/type-theme to _config.yml
  3. Switch from index.md to index.html to enable pagination

Known issues with this development gem are:

  • SCSS variables are not editable (fixed by @iMacTia)
  • Tags listing (tags.html) not available (fixed by @sylhare)
@sylhare
Copy link
Contributor

sylhare commented Nov 2, 2017

Allo @rohanchandra ,

For this one, I am not sure what the problem is.

  • Do you want to have the tags.html file in your gem?
  • For the scss variables, do you mean that the user will have to go in the file which would be in the gem to modify the variables?

For the "tags problem", I would know a quick fix.

@sylhare sylhare mentioned this issue Nov 5, 2017
@rohanchandra
Copy link
Owner Author

rohanchandra commented Nov 5, 2017

@sylhare That's right. There isn't an easy way to edit the SCSS variables at the moment using the gem version AFAIK.

Regarding the tags.html problem, we'd need a way to let the user enable tags (maybe this is something to add to the documentation as well).

Please run a quick test for the tags.html using the gem version to check if your fix works 👍 , happy to merge it in.

@sylhare
Copy link
Contributor

sylhare commented Nov 5, 2017

Oh you mean you've published a new version online of the gem? I have only tried locally so far. And I got the tags.html in my unpacked gem.

EDIT: Oh but like, you can't really switch back hide:true I mean, you either need to unpack the gem to get the file or you need to have it set to true.
Maybe we could move that "hide" thing into the _config.yml ?

@sylhare
Copy link
Contributor

sylhare commented Nov 6, 2017

Or define a layout for tags and search, then creating the page would just be creating a search.html with this front matter:

---
layout: tags
---

A bit like what is done with the index.html page. And for the customisation, well you would not use a gem if you wanted to customize the temlate, you would directly fork/clone the repository.

@rohanchandra
Copy link
Owner Author

Awesome @sylhare. Let's move the hide variable to the _config.yml, as I think we can read in the variable when setting up the navigation.

This was referenced Nov 14, 2017
@rohanchandra rohanchandra changed the title Gem version Gem version / GitHub Pages remote_theme support Jan 17, 2018
@divayprakash
Copy link
Contributor

@rohanchandra Only SCSS cars are remaining to fix here?

@rohanchandra
Copy link
Owner Author

@divayprakash It's been a while since I've worked on this, but the remaining task is to figure out how to expose the SCSS customization of the theme when using the gem version.

See _variables.scss which allows customization of the color and fonts with Google Fonts.

@rohanchandra
Copy link
Owner Author

The SCSS variables feature for remote themes has been added by @iMacTia, with instructions now in the README!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants