Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'jekyll-theme-type' to gemfile #71

Closed

Conversation

nickolasclarke
Copy link

currently the theme doesnt work on the gh-pages branch unless you add jekyll-theme-type gem to the gemfile, or install manually, as expected.

@sylhare
Copy link
Contributor

sylhare commented Jan 15, 2018

Well I think Github sends you a warning, but I still see it up:
https://rohanchandra.github.io/type-theme/

Or do you mean, using the theme as a gem, in that case it might be related to #59

@nickolasclarke
Copy link
Author

nickolasclarke commented Jan 16, 2018

@sylhare I was trying to run it locally, which wouldnt work unless the gem was installed, as per line 82 of the _config.yml: theme: jekyll-theme-type. This line also is incompatible with gh pages, since it wants a remote-theme: user/repo var in lieu of theme if the theme being used is not one of the 12 official. Anyhow, I think addressing #59 and cleaning up these inconsistencies should solve it all. Feel free to close this PR in that case.

@rohanchandra
Copy link
Owner

rohanchandra commented Jan 17, 2018

@nickolasclarke @sylhare I've updated the gh-pages branch, and removed theme: jekyll-theme-type from _config.yml, and this seems to fix things.

I believe theme: jekyll-theme-type in _config.yml causes a build error, as Jekyll expects the gem-based theme to be installed first.

You're right that #59 is currently blocking the gem-based theme, as well as support for remote_theme in GitHub Pages, as remote_theme requires gem support. (@sylhare, did you manage to add support for SCSS variables in the Type-on-Strap gem?)

I won't merge in the changes here just yet as #59 needs to be fixed before using the theme as a gem 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants