Make sure rack_cache[:verbose] can be set #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
til
force-pushed
the
rack-cache-config-fix
branch
from
633f1c0
to
2fbed08
Compare
| @@ -116,7 +116,8 @@ def self.unsubscribe(component, subscriber) | |||
|
|
|||
| def self.setup(app) | |||
| self.application = app | |||
| app.config.action_dispatch.rack_cache[:verbose] = false if app.config.action_dispatch.rack_cache | |||
| app.config.action_dispatch.rack_cache[:verbose] = false if app.config.action_dispatch.rack_cache && | |||
There was a problem hiding this comment.
I suggest moving the boolean check into a method to make the code a bit cleaner.
There was a problem hiding this comment.
Thanks for the feedback! Now with private method.
|
Thank you, looks great so far. |
Before this change, the following config setting which is provided as example in production.rb of current rails versions: config.action_dispatch.rack_cache = true would result in a startup failure. Fixes roidrage#52
til
force-pushed
the
rack-cache-config-fix
branch
from
2fbed08
to
5595778
Compare
|
|
👯
| @@ -116,7 +116,7 @@ def self.unsubscribe(component, subscriber) | |||
|
|
|||
| def self.setup(app) | |||
| self.application = app | |||
| app.config.action_dispatch.rack_cache[:verbose] = false if app.config.action_dispatch.rack_cache | |||
| app.config.action_dispatch.rack_cache[:verbose] = false if rack_cache_hashlike?(app) | |||
There was a problem hiding this comment.
app.config.action_dispatch.rack_cache[:verbose] = !rack_cache_hashlike?(app)
More concise?
There was a problem hiding this comment.
That would not work - because then :[]= would always be called on rack_cache, raising the error that this commit is trying to fix.
There was a problem hiding this comment.
Mybad. I see now. I guess it's a somewhat confusing use of a predicate.
|
Thanks <3 |
benlovell
added a commit
that referenced
this pull request
Feb 1, 2015
Make sure rack_cache[:verbose] can be set
|
I think this would deserve a change log entry. 🎅 |
pxlpnk
added a commit
to pxlpnk/lograge
that referenced
this pull request
Feb 1, 2015
Closed
jdurand
added a commit
to jdurand/logstasher
that referenced
this pull request
Jan 28, 2016
This exploded for me. Copied a commit from lograge which solved the same issue: roidrage/lograge#103
jdurand
added a commit
to jdurand/logstasher
that referenced
this pull request
Jan 28, 2016
This exploded for me. Copied a commit from lograge which solved the same issue: roidrage/lograge#103
jdurand
added a commit
to jdurand/logstasher
that referenced
this pull request
Jan 28, 2016
This exploded for me. Copied a commit from lograge which solved the same issue: roidrage/lograge#103
jdurand
added a commit
to jdurand/logstasher
that referenced
this pull request
Jan 28, 2016
This exploded for me. Copied a commit from lograge which solved the same issue: roidrage/lograge#103
jdurand
added a commit
to jdurand/logstasher
that referenced
this pull request
Jan 28, 2016
This exploded for me. Copied a commit from lograge which solved the same issue: roidrage/lograge#103
jdurand
added a commit
to jdurand/logstasher
that referenced
this pull request
Jan 28, 2016
This exploded for me. Copied a commit from lograge which solved the same issue: roidrage/lograge#103
shadabahmed
pushed a commit
to shadabahmed/logstasher
that referenced
this pull request
Apr 12, 2020
This exploded for me. Copied a commit from lograge which solved the same issue: roidrage/lograge#103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the following config setting which is provided as
example in production.rb of current rails versions:
config.action_dispatch.rack_cache = true
would result in a startup failure.
Fixes #52