Add LTSV formatter

[takashi]

I added a new formatter which formats log with LTSV format

LTSV means "Labeled Tab-separated Values"
official site: http://ltsv.org/

The LTSV format focuses on access logs of web servers
and I think it is useful for logging.

[takashi]

format code styles and squashed commit

[pxlpnk]

Thank you for the PR 👍
The test file is missing the _spec suffix and think the tests could maybe test the actual format a bit to guarantee consistency.

[takashi]

@pxlpnk thank you for reviewing! fixed file name with _spec suffix and add bit spec to specify format

[pxlpnk]

Looks good. Here we would need some single quotes to make rubocop happy: https://github.com/takashi/lograge/blob/add-ltsv-formatter/spec/formatters/ltsv_spec.rb#L26

@benlovell any objections in merging this?

[takashi]

@pxlpnk opps, my bad. format style and squashed!

[benlovell]

LGTM. 👍 build failed on jruby-head though.

[takashi]

@benlovell thx for LGTM! but i think the reason of failure on jruby-head is different from this PR's change. WDYT?

[benlovell]

Yep agreed. It's unrelated.

[takashi]

@benlovell yep, but I cant merge without resolving this issue... ;(

[takashi]

upps, mistake for closing

[benlovell]

Well you've triggered another build now so that's useful 😄

[pxlpnk]

I opened an issue on the jRuby repo, lets see if we get any pointers on this: jruby/jruby#3102

For the rest, I am fine with merging it and adding jruby-head again to the allowed failures.

One wish is to change the commit message to Add LTSV formatter and its spec (capitalising the a in the add) to follow our guidelines.

[takashi]

@pxlpnk thanks for opening issue in jruby :)

And I fixed commit message by capitalizing a in add to follow guideline.

[takashi]

@pxlpnk how about this PR?

[benlovell]

@takashi I pushed a change to master 6ccae19 that temporarily allows failures for jruby-head in the build matrix. Rebase and we'll get this merged. 👍

[takashi]

@benlovell okay thanks! I merged the commit that allows failure for jruby-head into this PR 👍

[benlovell]

@takashi I'd prefer if we didn't introduce that unnecessary merge commit. Can you reset to 71ad31b and then rebase instead please? If you need help with this, give me a shout.

[takashi]

@benlovell I see, and I rebased merge commit 👍 If i misunderstand your opinion, please let me know

[pxlpnk]

Rebase is perfect. A capitalized A in the add and we are ready to go! 👯
Thank you so much for your effort @takashi 💚

[takashi]

@pxlpnk upps, i forgot to capitalize a, and fixed it! thank you too @pxlpnk and @benlovell 🙏

[pxlpnk]

🚢

[benlovell]

😍 thanks

[takashi]

thx for merging!