Add :ttl configuration option #84
Conversation
pkarman
force-pushed
the
pek-alternate-expiration-config-key
branch
4 times, most recently
from
02a72cb
to
bdd1b2b
Compare
**Why**: The :expire_after config option controls both the Redis session expiration and the expiration of the Rails session cookie. Adding a new config option :ttl allows those controls to be managed separately. The most common case would be if you wanted the Rails cookie to expire when the browser is closed, as it would if :expire_after were set to `nil`.
pkarman
force-pushed
the
pek-alternate-expiration-config-key
branch
from
bdd1b2b
to
71053a9
Compare
|
Hello @Jesterovskiy. Is this something you would consider adding to this gem? It looks like there is interest in this feature given that there is another similar PR #85, but we haven't heard anything from the maintainers. Who are the current maintainers? |
|
@monfresh as I understand, this project doesn't have active maintainers now. I get permission for merge and release, because asking about my PR =) So, if you need to merge/release something - you can ask me, but I don't have vision, what features needed or not =( |
|
@Jesterovskiy afaik, "permission for merge and release" is pretty much the definition of a maintainer. So congratulations! :) If you have the power to merge this PR and release it, that would be great. @monfresh can confirm but I believe it represents working production code. The travis failures appear to be rubocop only, afaics. Those should be fixable. |
|
Yes, I confirm that we are using this code in production from our forked repo. Thanks for merging! Hi @pkarman! |
|
@Jesterovskiy Please let me know once you push a new release to rubygems. Thanks! |
|
@monfresh release is done) |
Why: The :expire_after config option controls both the Redis
session expiration and the expiration of the Rails session cookie.
Adding a new config option :ttl allows those controls to be
managed separately.
The most common case would be if you wanted the Rails cookie
to expire when the browser is closed, as it would if :expire_after
were set to
nil.