Delete generate_reflection #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am potentially worried about the builds failing. Do they fail on I am confused either way, but knowing if it's this changes' fault feels important. |
|
I'm investigating currently. I can't determine why CI is failing. I haven't gotten it to happen locally yet, and I've ensured on the same version of Rust as CI (1.76.0) - but I'll keep you updated! |
|
I re-ran the build job on master and it fails in the same way: https://github.com/rojo-rbx/rbx-dom/actions/runs/7977827973/job/22222750855. So it's not related to this PR, at least. |
|
All righty then. I suppose we can merge this, then. We should prioritize fixing the CI though. |
This was referenced Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate_reflection was superseded by rbx_reflector in #249. rbx_reflector still has a few issues here and there, but we're now using it entirely in favor of generate_reflection. generate_reflection has not received any updates since, may not work properly anymore, increases compilation times to no purpose, and its presence could confuse new contributors, so it should be removed.