Fix tests by borrowing attributes value in roundtrip test #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennethloeffler
changed the title
|
Closing this because it will Soon be fixed upstream at insta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After doing tests with a totally clean build (running
cargo cleanon the workspace, deletingCargo.lock, then runningcargo test --all-featureson the workspace), I was able to trace the CI failure we noticed in #398 to an unintentionally breaking change that was shipped as part of a minor version bump to an external library: mitsuhiko/insta#385. It looks like previous versions of the_assert_serialized_snapshotmacro borrowed the value, while the new one takes ownership. It is probably better for us to explicitly borrow the value here, but I'll still let them know that this change was breaking