Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent syncing when a sync is already happening #61

Closed
LPGhatguy opened this issue Apr 12, 2018 · 1 comment
Closed

Prevent syncing when a sync is already happening #61

LPGhatguy opened this issue Apr 12, 2018 · 1 comment
Labels
type: bug Something happens that shouldn't happen
Milestone
0.4.5

Comments

@LPGhatguy
Copy link
Member

Right now, if two syncs happen at the same time, I think they'll clash with eachother and potentially cause some terrible bugs.

As a stop-gap until a better solution is realized, there should be a global lock on syncing.
@LPGhatguy LPGhatguy added the type: bug Something happens that shouldn't happen label Apr 12, 2018
@LPGhatguy LPGhatguy added this to the 0.4.5 milestone Apr 12, 2018
@LPGhatguy
Copy link
Member Author

This is actually kind of tricky with the way it interacts with polling.

Dekkonot pushed a commit to UpliftGames/rojo that referenced this issue Jan 11, 2024
@LPGhatguy
Prevent syncing while a sync is already in progress.
52454e5 
I'm fairly confident that there will be zero cases where the plugin gets
into a bad state where you can't sync.

This change also prefixes most of Rojo's messages with `Rojo:` to make
them easier to identify.

Fixes rojo-rbx#61.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something happens that shouldn't happen
Projects
None yet
Milestone
0.4.5
Development

No branches or pull requests
1 participant
@LPGhatguy