Support the new Open Cloud API #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kampfkarren
reviewed
Dec 6, 2021
|
I believe this build is ready to be merged btw, The last commit was just to fix some formatting issues found with cargo fmt. |
Apparently my earlier fix did not fix everything.
Forgot to add the link to issue rojo-rbx#486 in the previous commit :/
LPGhatguy
requested changes
Dec 8, 2021
LPGhatguy
approved these changes
Apr 19, 2022
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
* Add support for the new Open Cloud API * Cleanup Open Cloud variables * Avoid cloning buffer for do_upload_open_cloud * Satisfy cargo fmt * Actually correct cargo fmt Apparently my earlier fix did not fix everything. * Update CHANGELOG.md * Update CHANGELOG.md Forgot to add the link to issue rojo-rbx#486 in the previous commit :/ * Cleanup & improve code for open cloud api * Commit to force GH Actions to run (?) Co-authored-by: Lucien Greathouse <me@lpghatguy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #486 by providing a
--api_keyalong with--universe_idin place of--cookie. Universe ID is required in order to use the open cloud api.So new upload commands will look like
rojo upload --api_key <API_KEY> --asset_id <PLACE_ID> --universe_id <UNIVERSE_ID> [project file]Instead of
rojo upload --cookie <COOKIE> --asset_id <PLACE_ID> [project file]This was made with an accumulative ~3 hours of experience with rust, so I'm sure things could be done better and I'm open to suggestions. Most notably lines 48-68.