Add restore and copy command #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweibel
reviewed
Apr 16, 2018
rokka/sourceimages.go
Outdated
| // CopySourceImage copies a source image by hash from one org to another | ||
| // | ||
| // See: https://rokka.io/documentation/references/source-images.html | ||
| func (c *Client) CopySourceImage(source_org, hash string, destination_org string) error { |
There was a problem hiding this comment.
please use camelCase for the variable names
mweibel
reviewed
Apr 16, 2018
cmd/rokka/cli/sourceimages.go
Outdated
| } | ||
|
|
||
| var sourceImagesCopyCmd = &cobra.Command{ | ||
| Use: "copy [source_org] [hash] [destination_org]", |
There was a problem hiding this comment.
please use camelCase also for the doc placeholders. It doesn't really matter, just to be consistent.
mweibel
suggested changes
Apr 16, 2018
|
fixed the camelCase stuff |
chregu
force-pushed
the
add-restore-and-copy-command
branch
from
d066b91
to
0ff0347
Compare
mweibel
approved these changes
Apr 16, 2018
mweibel
changed the title
This was referenced Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.