allow leading space for bs:disable comments #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
commented
Jun 9, 2020
| @@ -121,16 +121,13 @@ export class BrsFile { | |||
| throw new Error(`File was already processed. Create a new instance of BrsFile instead. ${this.pathAbsolute}`); | |||
| } | |||
|
|
|||
| //split the text into lines | |||
| let lines = util.getLines(fileContents); | |||
There was a problem hiding this comment.
This is a nice benefit, we no longer need to split the file contents by line and process it, since getIgnores works on the list of tokens now.
TwitchBronBron
commented
Jun 9, 2020
| /** | ||
| * Small tokenizer for bs:disable comments | ||
| */ | ||
| public tokenizeBsDisableComment(token: Token) { |
There was a problem hiding this comment.
Simple little tokenizer/parser function that makes dealing with disable comments easier.
TwitchBronBron
commented
Jun 9, 2020
| if (tokenized.disableType === 'line') { | ||
| affectedRange = Range.create(token.range.start.line, 0, token.range.start.line, token.range.start.character); | ||
| } else if (tokenized.disableType === 'next-line') { | ||
| affectedRange = Range.create(token.range.start.line + 1, 0, token.range.start.line + 1, Number.MAX_SAFE_INTEGER); |
There was a problem hiding this comment.
We used to find the length of the next line, but there's no real benefit to doing that, so just use MAX_SAFE_INTEGER instead because that will definitely match anything on the next line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
bs:disable-lineandbs:disable-next-linecomments do not support leading spaces. There's no reason not to, so this PR fixes that.