Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xml typedef inheritance fix #252

Merged
merged 10 commits into from
Dec 22, 2020
Merged

Conversation

TwitchBronBron
Copy link
Member

This fixes a bug where the typedefs in parent components were not properly recognized in child component scopes.

I've introduced the concept of "own" files for scopes:

  • all files: every file the scope references, either in its own direct references, or from parent scopes (like xml component inheritance)
  • own files: only files directly referenced by the current scope (does not account for parent scope files)

@TwitchBronBron
Copy link
Member Author

@georgejecook can you please review this, and then also test it out with your projects (since you were the one who found this issue).

@TwitchBronBron TwitchBronBron merged commit 51604d9 into master Dec 22, 2020
@TwitchBronBron TwitchBronBron deleted the xml-typedef-inheritance-fix branch December 22, 2020 20:10
@TwitchBronBron
Copy link
Member Author

@georgejecook thanks for testing the PR and verifying it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants