bslib ropm support #334
Merged
bslib ropm support #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove config option.
elsassph
reviewed
Feb 27, 2021
src/Scope.ts
Outdated
| @@ -835,6 +836,10 @@ export class Scope { | |||
| let referencedFile = this.getFileByRelativePath(scriptImport.pkgPath); | |||
| //if we can't find the file | |||
| if (!referencedFile) { | |||
| //skip the default bslib file, it will exist at transpile time but should not show up in the program during validation cycle | |||
| if (s`${scriptImport.pkgPath}` === `source${path.sep}bslib.brs`) { | |||
There was a problem hiding this comment.
Do you need path.sep? Does scriptImport.pkgPath need to be normalized?
There was a problem hiding this comment.
Yeah we need path.sep right now. Until #329 merges, pkgPath uses windows separators on windows and unix slashes everywhere else.
I'll check on whether scriptImport is already normalized elsewhere, perhaps we can skip this normalization.
There was a problem hiding this comment.
yeah, scriptImport has already been normalized, so this is redundant. i removed it. good catch!
|
@elsassph i believe ci have addressed all of your concerns. |
elsassph
approved these changes
Feb 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auto-detect if bslib is installed as a ropm module, and don't copy our version of bslib during transpile if true (in favor of using the version from ropm).