Fix crashes for clients that don't support "workspace/configuration" requests #667
Conversation
| ]); | ||
| }); | ||
|
|
||
| it('ignores bsconfig.json files from vscode ignored paths', async () => { |
There was a problem hiding this comment.
Deleted this totally duplicate unit test
|
I know this is a bit unrelated to the PR, but do you think you can add another binary that expose the language server as a standalone application? |
Let's discuss this back in #665 |
| }; | ||
| //if supported, ask vscode for the `files.exclude` configuration |
There was a problem hiding this comment.
Shouldn't this comment use the generic "client" instead of specifically mentioning "vscode"?
There was a problem hiding this comment.
The files and files.exclude are specific to VSCode. I have no idea what other editors to do handle including/excluding files from the workspace, but they're probably doing it differently than this. So, the comment still makes sense, and we can enhance the comment in the future as we add support for other editors.
There was a problem hiding this comment.
That's true that the specific configuration options are not part of the standard. Although there are other clients such as Theia that model their settings after VS Code.
Prevent several crashes related to the language server incorrectly assuming that all clients support "workspace/configuration".