Unit test cleanup #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into unit-test-cleanup
|
Closing in favor of #75 |
|
Oops, closed the wrong one! |
|
Something isn't right. The code running in those "push" builds don't seem to be running the correct code. |
|
Finally figured it out. The whole problem with these tests were the |
TwitchBronBron
commented
Oct 23, 2021
| "nyc": "^15.1.0", | ||
| "rimraf": "^2.6.2", | ||
| "sinon": "^11.1.2", | ||
| "source-map-support": "^0.5.13", | ||
| "testdouble": "^3.5.2", | ||
| "ts-mocha": "^6.0.0", |
There was a problem hiding this comment.
Removed this because mocha has built-in support for loading typescript (as seen in the mocha config below)
TwitchBronBron
commented
Oct 23, 2021
| "mocha": "^9.1.3", | ||
| "node-run-cmd": "^1.0.1", |
There was a problem hiding this comment.
remove this in favor of using child_process directly
chrisdp
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix many issues in the unit tests. Remove reliance on the test project in favor of creating files in each unit test instead.
I had to do some package upgrading too to get things working. This replaces #74 because this PR fixes the unit tests that one couldn't resolve.