-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test cleanup #75
Conversation
…into unit-test-cleanup
Closing in favor of #75 |
Oops, closed the wrong one! |
Something isn't right. The code running in those "push" builds don't seem to be running the correct code. |
Finally figured it out. The whole problem with these tests were the |
"nyc": "^15.1.0", | ||
"rimraf": "^2.6.2", | ||
"sinon": "^11.1.2", | ||
"source-map-support": "^0.5.13", | ||
"testdouble": "^3.5.2", | ||
"ts-mocha": "^6.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this because mocha has built-in support for loading typescript (as seen in the mocha
config below)
"mocha": "^9.1.3", | ||
"node-run-cmd": "^1.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this in favor of using child_process
directly
Fix many issues in the unit tests. Remove reliance on the test project in favor of creating files in each unit test instead.
I had to do some package upgrading too to get things working. This replaces #74 because this PR fixes the unit tests that one couldn't resolve.