add AssertAAContains #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duchuyctlk
reviewed
May 11, 2018
| Function BTS__AssertAAContains(expected as object, actual as object, msg = "" as string) as string | ||
| if TF_Utils__IsAssociativeArray(expected) and TF_Utils__IsAssociativeArray(actual) | ||
| for each key in expected | ||
| if not actual[key] = expected[key] |
There was a problem hiding this comment.
IMO it could be better if you use m.eqValues(actual[key], expected[key]) (see BTS__AssertEqual as reference) to compare 2 dynamic values.
|
@slheavner thanks you for the pull request, this was already fixed in our major update: https://github.com/rokudev/unit-testing-framework/releases/tag/v.2.0.0 so, closing right now, as code is already present there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
takes an expected and actual AA, and checks that all fields in
expectedare equal inactual.actualcan have extra fields, hence thecontains