Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional hooks on django middleware #137

Closed
wants to merge 1 commit into from
Closed

Add additional hooks on django middleware #137

wants to merge 1 commit into from

Conversation

filwaitman
Copy link
Contributor

Hi folks!

Firstly, thanks for this great project!

I just added a few hooks to allow custom payload/extra data via django middleware. Please take a look.

I executed the tests and they are ok. I didn't create any tests because I don't find a basis for django middleware test cases, though.

Please let me know if you want some changes on this PR.

Once again, thanks!

@ezarowny
Copy link
Contributor

Hey @filwaitman. We'll be reviewing this fairly soon. Sorry to leave you hanging there for a few days!

@filwaitman
Copy link
Contributor Author

@ezarowny don't worry, take your time! =]

@ezarowny
Copy link
Contributor

ezarowny commented Oct 26, 2016

Some initial feedback:

  • I'm releasing an updated version of the Django middleware in update Django middleware to support 1.10+ #138. I'll ping you again when it's released so you can rebase your changes off of that.
  • Can you revert your change to the __version__ variable? I usually make a separate commit for releases.

@filwaitman
Copy link
Contributor Author

@ezarowny sure! I'll revert the __version__ changes and wait for #138 to be closed.

@ezarowny
Copy link
Contributor

v0.13.7 has been released to PyPI. You should be good to base your changes off of that now.

@filwaitman
Copy link
Contributor Author

@ezarowny done!

Closing this one, in favour of #139

@filwaitman filwaitman closed this Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants