Add additional hooks on django middleware

[filwaitman]

Child of #137 (see this for the entire thread)

[ezarowny]

Ah, I see what you might want to do here. I'm going to discuss this with another engineer. Could be useful!

[ezarowny]

Hey there, just wanted to say that we haven't forgotten about you. We want to support this feature and we're trying to decide the best way to go about it.

[filwaitman]

hahaha

ok @ezarowny, no rush! =]

[ezarowny]

Hey @filwaitman, sorry for the delay there.

The middleware solution you presented is definitely a valid way to go about this but I've been trying to think of a way that would feel more official. As far as I know, you can't pass any arguments to the __init__(...) function of a Django Middleware.

As Django's settings files are just Python files, what do you think about storing or importing the get_payload_data and get_extra_data functions into your Django settings file? We could then look for them when initializing the Middleware?

I'm not sure if this is actually any simpler yet. Just an idea I've been mulling over.

[filwaitman]

Hi!

Sounds a good idea.
I can't work on it now, though. I guess next month I can do that.

[ezarowny]

Oh that's alright. I'll get a PR together with how I think this should work and I'll tag you so we can discuss it.

[filwaitman]

Ok, sounds perfect!

[coryvirok]

@ezarowny what's next for this PR?

[ezarowny]

Just need to write up the handlers for Django and test it out.

[GabLeRoux]

I'm interested in this as well, any progress or plan to support this? I'm looking for a way to specify which user had the problem with some stacktrace and this seems like a potential solution.

[GabLeRoux]

I tested this pull request on top of latest master branch and I confirm it works as expected. I see custom keys in params on the rollbar dashboard 👍

Any plan to merge this?

Example I used:

from rollbar.contrib.django.middleware import RollbarNotifierMiddleware

class CustomRollbarNotifierMiddleware(RollbarNotifierMiddleware):

    @staticmethod
    def get_extra_data(request, exc):
        try:
            # returning user here is kind of pointless as it's already included in `person`
            # but still, this is a valid example
            return dict({'user': request.user})
        except Exception:
            # if things go wrong, don't make it worst and let the rollbar notification leave
            return None

[rokob]

This looks good as is to me