Fix params to handle_error() in Pyramid middleware #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the original fix in 311eb45 I had missed that the addition of exc_info was not the only change in the signature of the handle_error function: - before: handle_error(settings, request) - after: handle_error(request, exception, exc_info) Thanks to @indepndnt for noticing the problem!
|
@ronnix Great catch! This inclines me to ponder if a simple test would help, considering we've made the mistake twice now. What do you think? |
|
@corps you're absolutely right. here is a test that would have caught both issues. |
ronnix
force-pushed
the
fix-pyramid-middleware-2
branch
from
9de2965
to
37d6ee3
Compare
|
Thank you! This looks great, I'll merge and cut a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original fix in #283 I had missed that the addition of
exc_infowas not the only change in the signature of thehandle_errorfunction:handle_error(settings, request)handle_error(request, exception, exc_info)Thanks to @indepndnt for noticing the problem!