Refactor all the things #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd google checkstyle rules. Ideas behind this new set of classes are: * Fluent API through Builders included in each class. * Immutable classes. An example of use of how to build each different payload the factory class under the test's util package would be a good starting point.
Add a new set of classes that represents the Rollbar's API and also a…
This new version of the notifier has the following features: * Same API like the previous version for sending messages. Methods like log, critical, error...etc has the same signature. * Introduced new APIs to gather external data and allow future integrations. * Library managed instance. * New pipeline for data processing with the following steps. * Uncaught exception handler with delegation to previously set handler. ** Gather external data through the new interfaces. ** Filter process with two steps for preTransform and preSend steps. ** Transformation of the payload before sending. ** UUID generator. ** Fingerprint generator. ** Send payload.
At this point the example is part of the build, but this is something that could be changed later to use the published dependency.
Add rollbar-java definitions.
The idea is to have senders that can notify to a set of listeners the result of a payload send. Changes introduced are: * Rename callback to listener to be more representative. * The listener methods now receive also the payload to have a reference to the payload that caused the result. * Remove the option from config because now this listeners are set in the sender and the notifier should not know anything regarding them, that ends up being decoupled. Move to an approach where senders can notify of results through listeners instead of a callback executed every time an event is sent. Also, modified the previous sender callback interface to a sender listener name, and added the payload send to the listener's methods.
This abstract sender is added to allow code reuse regarding the notifications to listener handling. Also, this class allows simplified implementations of senders.
The senders probably will be handling external resources, so through this change now the senders have a method that allow implementations to free them up.
Changes done: * Sender interface now has a method to retrieve the sender's listeners. This helps with delegation. * Make JsonSerializable inherits from Serializable to allow serializing the payloads to disk. * The different data structures of our API should contain objects that are Serializable in order to use the disk queue, if not it will fail serializing/deserializing. * Add a sender that is buffered by a queue and executes in another thread the sending of the payloads. * Add a disk queue.
Add web integration and example.
…er, use that in android
…and actually works
…ration functions now
…clean up person provider
…o ensure that works
…so we only want to fail if it is false
…ommenting out for now
…on the singleton instance so all of the instance methods can be called without a static alias
Android on top of rollbar-java
Add publishing with maven-publish plugin and signing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before pushing the alpha release out it makes sense to have the code living on master. So this PR is to merge all the work from sdk-refactor onto master.