-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed MonologHandler conflict while using rollbar agent #108
Conversation
@bishopb @brianr @waltjones @jenssegers @ArturMoczulski can you please review and merge this change? |
Hi @Lukasz93P, we will aim to get this reviewed soon, but probably not until next week. The fastest path to resolve your production app issue is probably to install your branch directly, something like this: https://getcomposer.org/doc/05-repositories.md#loading-a-package-from-a-vcs-repository (note you'll probably need to rename the branch to start with |
@brianr I know that but I didnt want to have to do this. |
@brianr can someone review this pr ? BTW I figured out that renaming branch is not necessary, now I have dev-dev ;) because dev prefix is not part of the branch name. |
Thanks for the contribution, @Lukasz93P. I've taken this in a slightly different direction. Would you mind trying Pull Request #109 in your environment to see if it works for you? |
@bishopb yes, I will try but I need at least few days for this. |
Thank you again for your contribution. I'm closing this one in favor of Pull Request #109. A new release will be cut soon. |
@bishopb unfortunately this solution also causes an error - |
This seems to be related to #106 which I just merged. Would you mind giving it a try @Lukasz93P ? |
Hi @bxsx, any update here? Can my PR be merged or maybe you have better solution(mentioned above is not worki g) ? |
Wasn't the issue resolved here #85 (comment) |
No it jus introduced another issue which I described here #108 (comment) |
@Lukasz93P what version of |
Description of the change
Resolver handler conflict while using rollbar agent handler. Bug which was describer here
Type of change
Related issues
Checklists
Development
Code review